strat9_kernel/shell/commands/sys/

mod.rs

//! System management commands
mod clear;
mod cpuinfo;
mod frame_meta;
mod health;
mod heap;
mod reboot;
mod scheduler;
mod shutdown;
mod silo_attach;
#[path = "silo.rs"]
mod silo_cmd;
mod silo_limit;
mod silos;
mod strate;
mod test_exec;
mod test_mem;
mod test_mem_region;
mod test_mem_region_proc;
mod test_mem_stressed;
mod test_pid;
mod test_syscalls;
mod trace;
mod version;
mod wasm_run;
pub use clear::cmd_clear;
pub use cpuinfo::cmd_cpuinfo;
pub use frame_meta::cmd_frame_meta;
pub use health::cmd_health;
pub use heap::cmd_heap;
pub use reboot::cmd_reboot;
pub use scheduler::cmd_scheduler;
pub use shutdown::cmd_shutdown;
pub use silo_cmd::cmd_silo;
pub use silos::cmd_silos;
pub use strate::cmd_strate;
pub use test_exec::cmd_test_exec;
pub use test_mem::cmd_test_mem;
pub use test_mem_region::cmd_test_mem_region;
pub use test_mem_region_proc::cmd_test_mem_region_proc;
pub use test_mem_stressed::cmd_test_mem_stressed;
pub use test_pid::cmd_test_pid;
pub use test_syscalls::cmd_test_syscalls;
pub use trace::cmd_trace;
pub use version::cmd_version;
pub use wasm_run::cmd_wasm_run;

use silo_attach::cmd_silo_attach;
use silo_limit::cmd_silo_limit;

use crate::{
    arch::x86_64::vga,
    memory,
    process::elf::load_and_run_elf,
    shell::{
        commands::top::Strat9RatatuiBackend,
        output::{clear_screen, format_bytes},
        ShellError,
    },
    shell_println, silo, vfs,
};
use alloc::{string::String, vec::Vec};
use ratatui::{
    layout::{Constraint, Direction, Layout},
    style::{Color, Modifier, Style},
    widgets::{Block, Borders, Cell, Paragraph, Row, Table},
    Terminal,
};

const STRATE_USAGE: &str = "Usage: strate <list|spawn|start|stop|kill|destroy|rename|config|info|suspend|resume|events|pledge|unveil|sandbox|limit|attach|top|logs> ...";
const SILO_USAGE: &str = "Usage: silo <list|spawn|start|stop|kill|destroy|rename|config|info|suspend|resume|events|pledge|unveil|sandbox|limit|attach|top|logs> ...";
const DEFAULT_MANAGED_SILO_TOML: &str = r#"
[[silos]]
name = "console-admin"
family = "SYS"
mode = "700"
sid = 42
[[silos.strates]]
name = "console-admin"
binary = "/initfs/console-admin"
type = "elf"

[[silos]]
name = "bus"
family = "DRV"
mode = "076"
sid = 42
[[silos.strates]]
name = "strate-bus"
binary = "/initfs/strate-bus"
type = "elf"

[[silos]]
name = "network"
family = "NET"
mode = "076"
sid = 42
[[silos.strates]]
name = "strate-net"
binary = "/initfs/strate-net"
type = "elf"

[[silos]]
name = "dhcp-client"
family = "NET"
mode = "076"
sid = 42
[[silos.strates]]
name = "dhcp-client"
binary = "/initfs/bin/dhcp-client"
type = "elf"

[[silos]]
name = "telnet"
family = "NET"
mode = "076"
sid = 42
[[silos.strates]]
name = "telnetd"
binary = "/initfs/bin/telnetd"
type = "elf"

[[silos]]
name = "web-admin"
family = "NET"
mode = "076"
sid = 42
graphics_enabled = true
graphics_mode = "webrtc-native"
graphics_max_sessions = 1
graphics_session_ttl_sec = 1800
graphics_turn_policy = "auto"
[[silos.strates]]
name = "web-admin"
binary = "/initfs/bin/web-admin"
type = "elf"

[[silos]]
name = "graphics-webrtc"
family = "NET"
mode = "076"
sid = 42
[[silos.strates]]
name = "strate-webrtc"
binary = "/initfs/strate-webrtc"
type = "elf"
"#;

#[derive(Clone)]
struct ManagedStrateDef {
    name: String,
    binary: String,
    stype: String,
    target: String,
}

#[derive(Clone)]
struct ManagedSiloDef {
    name: String,
    sid: u32,
    family: String,
    mode: String,
    cpu_features: String,
    graphics_enabled: bool,
    graphics_mode: String,
    graphics_read_only: bool,
    graphics_max_sessions: u16,
    graphics_session_ttl_sec: u32,
    graphics_turn_policy: String,
    strates: Vec<ManagedStrateDef>,
}

/// Parses silo toml.
fn parse_silo_toml(data: &str) -> Vec<ManagedSiloDef> {
    #[derive(Clone, Copy)]
    enum Section {
        Silo,
        Strate,
    }

    /// Performs the push default strate operation.
    fn push_default_strate(silo: &mut ManagedSiloDef) {
        silo.strates.push(ManagedStrateDef {
            name: String::new(),
            binary: String::new(),
            stype: String::from("elf"),
            target: String::from("default"),
        });
    }

    let mut silos = Vec::new();
    let mut current_silo: Option<ManagedSiloDef> = None;
    let mut section = Section::Silo;

    for raw_line in data.lines() {
        let line = raw_line.trim();
        if line.is_empty() || line.starts_with('#') {
            continue;
        }
        if line == "[[silos]]" {
            if let Some(s) = current_silo.take() {
                silos.push(s);
            }
            current_silo = Some(ManagedSiloDef {
                name: String::new(),
                sid: 42,
                family: String::from("USR"),
                mode: String::from("000"),
                cpu_features: String::new(),
                graphics_enabled: false,
                graphics_mode: String::new(),
                graphics_read_only: false,
                graphics_max_sessions: 0,
                graphics_session_ttl_sec: 0,
                graphics_turn_policy: String::from("auto"),
                strates: Vec::new(),
            });
            section = Section::Silo;
            continue;
        }
        if line == "[[silos.strates]]" {
            if let Some(ref mut s) = current_silo {
                push_default_strate(s);
            }
            section = Section::Strate;
            continue;
        }
        if let Some(idx) = line.find('=') {
            let key = line[..idx].trim();
            let val = line[idx + 1..].trim().trim_matches('"');
            if let Some(ref mut s) = current_silo {
                match section {
                    Section::Silo => match key {
                        "name" => s.name = String::from(val),
                        "sid" => s.sid = val.parse().unwrap_or(42),
                        "family" => s.family = String::from(val),
                        "mode" => s.mode = String::from(val),
                        "cpu_features" => s.cpu_features = String::from(val),
                        "graphics_enabled" => {
                            s.graphics_enabled = matches!(val, "true" | "True" | "TRUE" | "1")
                        }
                        "graphics_mode" => s.graphics_mode = String::from(val),
                        "graphics_read_only" => {
                            s.graphics_read_only = matches!(val, "true" | "True" | "TRUE" | "1")
                        }
                        "graphics_max_sessions" => {
                            s.graphics_max_sessions = val.parse().unwrap_or(0)
                        }
                        "graphics_session_ttl_sec" => {
                            s.graphics_session_ttl_sec = val.parse().unwrap_or(0)
                        }
                        "graphics_turn_policy" => s.graphics_turn_policy = String::from(val),
                        _ => {}
                    },
                    Section::Strate => {
                        if s.strates.is_empty() {
                            push_default_strate(s);
                        }
                        if let Some(st) = s.strates.last_mut() {
                            match key {
                                "name" => st.name = String::from(val),
                                "binary" => st.binary = String::from(val),
                                "type" => st.stype = String::from(val),
                                "target_strate" => st.target = String::from(val),
                                _ => {}
                            }
                        }
                    }
                }
            }
        }
    }

    if let Some(s) = current_silo {
        silos.push(s);
    }
    silos
}

/// Performs the render silo toml operation.
fn render_silo_toml(silos: &[ManagedSiloDef]) -> String {
    use core::fmt::Write;
    let mut out = String::new();
    for (i, s) in silos.iter().enumerate() {
        if i > 0 {
            out.push('\n');
        }
        let _ = writeln!(out, "[[silos]]");
        let _ = writeln!(out, "name = \"{}\"", s.name);
        let _ = writeln!(out, "sid = {}", s.sid);
        let _ = writeln!(out, "family = \"{}\"", s.family);
        let _ = writeln!(out, "mode = \"{}\"", s.mode);
        if !s.cpu_features.is_empty() {
            let _ = writeln!(out, "cpu_features = \"{}\"", s.cpu_features);
        }
        if s.graphics_enabled {
            let _ = writeln!(out, "graphics_enabled = true");
            let mode = if s.graphics_mode.is_empty() {
                "webrtc-native"
            } else {
                s.graphics_mode.as_str()
            };
            let _ = writeln!(out, "graphics_mode = \"{}\"", mode);
            if s.graphics_read_only {
                let _ = writeln!(out, "graphics_read_only = true");
            }
            if s.graphics_max_sessions != 0 {
                let _ = writeln!(out, "graphics_max_sessions = {}", s.graphics_max_sessions);
            }
            if s.graphics_session_ttl_sec != 0 {
                let _ = writeln!(
                    out,
                    "graphics_session_ttl_sec = {}",
                    s.graphics_session_ttl_sec
                );
            }
            if s.graphics_turn_policy != "auto" && !s.graphics_turn_policy.is_empty() {
                let _ = writeln!(out, "graphics_turn_policy = \"{}\"", s.graphics_turn_policy);
            }
        }
        for st in &s.strates {
            out.push('\n');
            let _ = writeln!(out, "[[silos.strates]]");
            let _ = writeln!(out, "name = \"{}\"", st.name);
            let _ = writeln!(out, "binary = \"{}\"", st.binary);
            let _ = writeln!(out, "type = \"{}\"", st.stype);
            let _ = writeln!(out, "target_strate = \"{}\"", st.target);
        }
    }
    out
}

/// Reads silo toml from initfs.
fn read_silo_toml_from_initfs() -> Result<String, ShellError> {
    let path = "/initfs/silo.toml";
    match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => {
            let data = vfs::read_all(fd).map_err(|_| ShellError::ExecutionFailed)?;
            let _ = vfs::close(fd);
            let text = core::str::from_utf8(&data).map_err(|_| ShellError::ExecutionFailed)?;
            Ok(String::from(text))
        }
        Err(crate::syscall::error::SyscallError::NotFound) => Ok(String::new()),
        Err(_) => Err(ShellError::ExecutionFailed),
    }
}

/// Performs the load managed silos with source operation.
fn load_managed_silos_with_source() -> (Vec<ManagedSiloDef>, &'static str) {
    match read_silo_toml_from_initfs() {
        Ok(text) => {
            let parsed = parse_silo_toml(&text);
            if parsed.is_empty() {
                (
                    parse_silo_toml(DEFAULT_MANAGED_SILO_TOML),
                    "embedded-default",
                )
            } else {
                (parsed, "/initfs/silo.toml")
            }
        }
        Err(_) => (
            parse_silo_toml(DEFAULT_MANAGED_SILO_TOML),
            "embedded-default",
        ),
    }
}

fn family_uses_system_sid(family: &str) -> bool {
    matches!(family, "SYS" | "DRV" | "NET" | "FS")
}

fn compute_managed_runtime_sids(managed: &[ManagedSiloDef]) -> Vec<(String, u32)> {
    let mut ordered = managed.to_vec();
    ordered.sort_by_key(|s| if s.name == "bus" { 0u8 } else { 1u8 });

    let mut next_sys_sid = 100u32;
    let mut next_usr_sid = 1000u32;
    let mut mappings = Vec::new();

    for silo in ordered {
        let sid = if silo.sid == 42 {
            if family_uses_system_sid(&silo.family) {
                let id = next_sys_sid;
                next_sys_sid += 1;
                id
            } else {
                let id = next_usr_sid;
                next_usr_sid += 1;
                id
            }
        } else {
            silo.sid
        };
        mappings.push((silo.name, sid));
    }

    mappings
}

fn managed_name_for_runtime_sid(
    managed_runtime_sids: &[(String, u32)],
    sid: u32,
) -> Option<String> {
    managed_runtime_sids
        .iter()
        .find(|(_, mapped_sid)| *mapped_sid == sid)
        .map(|(name, _)| name.clone())
}

fn normalize_silo_selector(selector: &str, managed_runtime_sids: &[(String, u32)]) -> String {
    if selector.parse::<u32>().is_ok() {
        return String::from(selector);
    }

    managed_runtime_sids
        .iter()
        .find(|(name, _)| name == selector)
        .map(|(_, sid)| alloc::format!("{}", sid))
        .unwrap_or_else(|| String::from(selector))
}

fn normalize_current_silo_selector(selector: &str) -> String {
    let (managed, _) = load_managed_silos_with_source();
    let managed_runtime_sids = compute_managed_runtime_sids(&managed);
    normalize_silo_selector(selector, &managed_runtime_sids)
}

/// Performs the push unique operation.
fn push_unique(values: &mut Vec<String>, item: &str) {
    if !values.iter().any(|v| v == item) {
        values.push(String::from(item));
    }
}

/// Performs the join csv operation.
fn join_csv(values: &[String]) -> String {
    if values.is_empty() {
        return String::from("-");
    }
    let mut out = String::new();
    for (i, v) in values.iter().enumerate() {
        if i != 0 {
            out.push_str(", ");
        }
        out.push_str(v);
    }
    out
}

struct SiloListRow {
    sid: u32,
    name: String,
    state: String,
    tasks: usize,
    memory: String,
    mode: u16,
    label: String,
    strates: String,
}

struct RuntimeStrateRow {
    strate: String,
    belongs_to: String,
    status: String,
}

struct ConfigStrateRow {
    strate: String,
    belongs_to: String,
}

struct ConfigListRow {
    sid: u32,
    name: String,
    family: String,
    mode: String,
    strates: String,
}

/// Performs the render silo table ratatui operation.
fn render_silo_table_ratatui(
    runtime_rows: &[SiloListRow],
    config_rows: &[ConfigListRow],
    config_source: &str,
) -> Result<bool, ShellError> {
    if !vga::is_available() {
        return Ok(false);
    }

    let backend = Strat9RatatuiBackend::new().map_err(|_| ShellError::ExecutionFailed)?;
    let mut terminal = Terminal::new(backend).map_err(|_| ShellError::ExecutionFailed)?;
    terminal.clear().map_err(|_| ShellError::ExecutionFailed)?;

    let runtime_table_rows: Vec<Row> = runtime_rows
        .iter()
        .map(|r| {
            let mut style = Style::default().fg(Color::White);
            if r.strates == "-" {
                style = style.fg(Color::LightRed);
            } else {
                style = style.fg(Color::LightGreen);
            }
            Row::new(alloc::vec![
                Cell::from(alloc::format!("{}", r.sid)),
                Cell::from(r.name.as_str()),
                Cell::from(r.state.as_str()),
                Cell::from(alloc::format!("{}", r.tasks)),
                Cell::from(r.memory.as_str()),
                Cell::from(alloc::format!("{:o}", r.mode)),
                Cell::from(r.label.as_str()),
                Cell::from(r.strates.as_str()),
            ])
            .style(style)
        })
        .collect();
    let config_table_rows: Vec<Row> = config_rows
        .iter()
        .map(|r| {
            Row::new(alloc::vec![
                Cell::from(alloc::format!("{}", r.sid)),
                Cell::from(r.name.as_str()),
                Cell::from(r.family.as_str()),
                Cell::from(r.mode.as_str()),
                Cell::from(r.strates.as_str()),
            ])
            .style(Style::default().fg(Color::LightCyan))
        })
        .collect();

    let frame_started = vga::begin_frame();
    terminal
        .draw(|f| {
            let area = f.area();
            let vertical = Layout::default()
                .direction(Direction::Vertical)
                .constraints([
                    Constraint::Length(2),
                    Constraint::Min(10),
                    Constraint::Length(10),
                    Constraint::Length(1),
                ])
                .split(area);

            let title = Paragraph::new("Silo List")
                .style(
                    Style::default()
                        .fg(Color::Cyan)
                        .add_modifier(Modifier::BOLD),
                )
                .block(Block::default().borders(Borders::BOTTOM).title("Strat9"));
            f.render_widget(title, vertical[0]);

            let widths = [
                Constraint::Length(6),
                Constraint::Length(12),
                Constraint::Length(10),
                Constraint::Length(7),
                Constraint::Length(18),
                Constraint::Length(6),
                Constraint::Length(12),
                Constraint::Min(20),
            ];
            let runtime_table = Table::new(runtime_table_rows, widths)
                .header(
                    Row::new(alloc::vec![
                        Cell::from("SID"),
                        Cell::from("Name"),
                        Cell::from("State"),
                        Cell::from("Tasks"),
                        Cell::from("Memory"),
                        Cell::from("Mode"),
                        Cell::from("Label"),
                        Cell::from("Strates"),
                    ])
                    .style(
                        Style::default()
                            .fg(Color::Yellow)
                            .add_modifier(Modifier::BOLD),
                    ),
                )
                .block(
                    Block::default()
                        .borders(Borders::ALL)
                        .title("Runtime")
                        .border_style(Style::default().fg(Color::Green)),
                )
                .column_spacing(1);
            f.render_widget(runtime_table, vertical[1]);

            let config_widths = [
                Constraint::Length(6),
                Constraint::Length(14),
                Constraint::Length(8),
                Constraint::Length(8),
                Constraint::Min(20),
            ];
            let config_table = Table::new(config_table_rows, config_widths)
                .header(
                    Row::new(alloc::vec![
                        Cell::from("SID"),
                        Cell::from("Name"),
                        Cell::from("Family"),
                        Cell::from("Mode"),
                        Cell::from("Strates"),
                    ])
                    .style(
                        Style::default()
                            .fg(Color::Magenta)
                            .add_modifier(Modifier::BOLD),
                    ),
                )
                .block(
                    Block::default()
                        .borders(Borders::ALL)
                        .title(alloc::format!("Config ({})", config_source))
                        .border_style(Style::default().fg(Color::Magenta)),
                )
                .column_spacing(1);
            f.render_widget(config_table, vertical[2]);

            let footer = Paragraph::new("runtime vert=associe | runtime rouge=incomplet")
                .style(Style::default().fg(Color::DarkGray));
            f.render_widget(footer, vertical[3]);
        })
        .map_err(|_| ShellError::ExecutionFailed)?;
    if frame_started {
        vga::end_frame();
    }
    Ok(true)
}

/// Performs the render strate table ratatui operation.
fn render_strate_table_ratatui(
    runtime_rows: &[RuntimeStrateRow],
    config_rows: &[ConfigStrateRow],
    config_source: &str,
) -> Result<bool, ShellError> {
    if !vga::is_available() {
        return Ok(false);
    }

    let backend = Strat9RatatuiBackend::new().map_err(|_| ShellError::ExecutionFailed)?;
    let mut terminal = Terminal::new(backend).map_err(|_| ShellError::ExecutionFailed)?;
    terminal.clear().map_err(|_| ShellError::ExecutionFailed)?;

    let runtime_table_rows: Vec<Row> = runtime_rows
        .iter()
        .map(|r| {
            let style = if r.status == "config+runtime" {
                Style::default().fg(Color::LightGreen)
            } else {
                Style::default().fg(Color::LightYellow)
            };
            Row::new(alloc::vec![
                Cell::from(r.strate.as_str()),
                Cell::from(r.belongs_to.as_str()),
                Cell::from(r.status.as_str()),
            ])
            .style(style)
        })
        .collect();
    let config_table_rows: Vec<Row> = config_rows
        .iter()
        .map(|r| {
            Row::new(alloc::vec![
                Cell::from(r.strate.as_str()),
                Cell::from(r.belongs_to.as_str()),
            ])
            .style(Style::default().fg(Color::LightCyan))
        })
        .collect();

    let frame_started = vga::begin_frame();
    terminal
        .draw(|f| {
            let area = f.area();
            let vertical = Layout::default()
                .direction(Direction::Vertical)
                .constraints([
                    Constraint::Length(2),
                    Constraint::Min(8),
                    Constraint::Length(8),
                    Constraint::Length(1),
                ])
                .split(area);

            let title = Paragraph::new("Strate List")
                .style(
                    Style::default()
                        .fg(Color::Cyan)
                        .add_modifier(Modifier::BOLD),
                )
                .block(Block::default().borders(Borders::BOTTOM).title("Strat9"));
            f.render_widget(title, vertical[0]);

            let runtime_widths = [
                Constraint::Length(22),
                Constraint::Min(24),
                Constraint::Length(16),
            ];
            let runtime_table = Table::new(runtime_table_rows, runtime_widths)
                .header(
                    Row::new(alloc::vec![
                        Cell::from("Strate"),
                        Cell::from("BelongsTo"),
                        Cell::from("Status"),
                    ])
                    .style(
                        Style::default()
                            .fg(Color::Yellow)
                            .add_modifier(Modifier::BOLD),
                    ),
                )
                .block(
                    Block::default()
                        .borders(Borders::ALL)
                        .title("Runtime")
                        .border_style(Style::default().fg(Color::Green)),
                )
                .column_spacing(2);
            f.render_widget(runtime_table, vertical[1]);

            let config_widths = [Constraint::Length(22), Constraint::Min(24)];
            let config_table = Table::new(config_table_rows, config_widths)
                .header(
                    Row::new(alloc::vec![Cell::from("Strate"), Cell::from("BelongsTo")]).style(
                        Style::default()
                            .fg(Color::Magenta)
                            .add_modifier(Modifier::BOLD),
                    ),
                )
                .block(
                    Block::default()
                        .borders(Borders::ALL)
                        .title(alloc::format!("Config ({})", config_source))
                        .border_style(Style::default().fg(Color::Magenta)),
                )
                .column_spacing(2);
            f.render_widget(config_table, vertical[2]);

            let footer = Paragraph::new("vert=config+runtime, jaune=runtime-only")
                .style(Style::default().fg(Color::DarkGray));
            f.render_widget(footer, vertical[3]);
        })
        .map_err(|_| ShellError::ExecutionFailed)?;
    if frame_started {
        vga::end_frame();
    }
    Ok(true)
}

/// Writes silo toml to initfs.
fn write_silo_toml_to_initfs(text: &str) -> Result<(), ShellError> {
    let path = "/initfs/silo.toml";
    let fd = vfs::open(
        path,
        vfs::OpenFlags::WRITE | vfs::OpenFlags::CREATE | vfs::OpenFlags::TRUNCATE,
    )
    .map_err(|_| ShellError::ExecutionFailed)?;
    let bytes = text.as_bytes();
    let mut written = 0usize;
    while written < bytes.len() {
        let n = vfs::write(fd, &bytes[written..]).map_err(|_| ShellError::ExecutionFailed)?;
        if n == 0 {
            let _ = vfs::close(fd);
            return Err(ShellError::ExecutionFailed);
        }
        written += n;
    }
    let _ = vfs::close(fd);
    Ok(())
}

/// Performs the print strate state for sid operation.
fn print_strate_state_for_sid(sid: u32) {
    if let Some(s) = silo::list_silos_snapshot()
        .into_iter()
        .find(|s| s.id == sid)
    {
        shell_println!("state: {:?}", s.state);
    } else {
        shell_println!("state: <unknown>");
    }
}

fn print_strate_usage() {
    shell_println!("{}", STRATE_USAGE);
    shell_println!("  strate list");
    shell_println!("  strate spawn <path|type> [--label <l>] [--dev <p>] [--type elf|wasm]");
    shell_println!("  strate start <id|label>");
    shell_println!("  strate stop|kill|destroy <id|label>");
    shell_println!("  strate rename <id|label> <new_label>");
    shell_println!("  strate config show|add|remove ...");
    shell_println!("  strate info <id|label>");
    shell_println!("  strate suspend|resume <id|label>");
    shell_println!("  strate events [id|label]");
    shell_println!("  strate pledge <id|label> <octal_mode>");
    shell_println!("  strate unveil <id|label> <path> <rwx>");
    shell_println!("  strate sandbox <id|label>");
    shell_println!("  strate top [--sort mem|tasks]");
    shell_println!("  strate logs <id|label>");
}

fn print_silo_usage() {
    shell_println!("{}", SILO_USAGE);
    shell_println!("  silo list [--gui]");
    shell_println!("  silo spawn <path|type> [--label <l>] [--dev <p>] [--type elf|wasm]");
    shell_println!("  silo start <id|label>");
    shell_println!("  silo stop|kill|destroy <id|label>");
    shell_println!("  silo rename <id|label> <new_label>");
    shell_println!("  silo config show|add|remove ...");
    shell_println!("  silo info <id|label>");
    shell_println!("  silo suspend|resume <id|label>");
    shell_println!("  silo events [id|label]");
    shell_println!("  silo pledge <id|label> <octal_mode>");
    shell_println!("  silo unveil <id|label> <path> <rwx>");
    shell_println!("  silo sandbox <id|label>");
    shell_println!("  silo limit <id|label> <mem_max|mem_min|max_tasks|cpu_shares> <value>");
    shell_println!("  silo attach <id|label>");
    shell_println!("  silo top [--sort mem|tasks]");
    shell_println!("  silo logs <id|label>");
}

pub(super) fn cmd_silo_impl(args: &[String]) -> Result<(), ShellError> {
    if args.is_empty() {
        print_silo_usage();
        return Err(ShellError::InvalidArguments);
    }
    match args[0].as_str() {
        "list" => cmd_silo_list(args),
        "info" => cmd_silo_info(args),
        "suspend" => cmd_silo_suspend(args),
        "resume" => cmd_silo_resume(args),
        "events" => cmd_silo_events(args),
        "pledge" => cmd_silo_pledge(args),
        "unveil" => cmd_silo_unveil(args),
        "sandbox" => cmd_silo_sandbox(args),
        "limit" => cmd_silo_limit(args),
        "attach" => cmd_silo_attach(args),
        "top" => cmd_silo_top(args),
        "logs" => cmd_silo_logs(args),
        "spawn" | "start" | "stop" | "kill" | "destroy" | "rename" | "config" => cmd_strate(args),
        _ => {
            print_silo_usage();
            Err(ShellError::InvalidArguments)
        }
    }
}

/// Performs the cmd silos operation.
pub(super) fn cmd_silos_impl(_args: &[String]) -> Result<(), ShellError> {
    let args = [String::from("list")];
    cmd_silo(&args)
}

/// Display kernel version
pub(super) fn cmd_version_impl(_args: &[String]) -> Result<(), ShellError> {
    shell_println!("Strat9-OS v0.1.0 (Bedrock)");
    shell_println!("Build: x86_64-unknown-none");
    shell_println!("Features: SMP, APIC, VirtIO, IPC, Schemes");
    Ok(())
}

/// Clear the screen
pub(super) fn cmd_clear_impl(_args: &[String]) -> Result<(), ShellError> {
    clear_screen();
    Ok(())
}

/// Display CPU information
pub(super) fn cmd_cpuinfo_impl(_args: &[String]) -> Result<(), ShellError> {
    shell_println!("CPU information:");

    if crate::arch::x86_64::apic::is_initialized() {
        let lapic_id = crate::arch::x86_64::apic::lapic_id();
        let cpu_count = crate::arch::x86_64::percpu::cpu_count();
        shell_println!("  Current LAPIC ID:  {}", lapic_id);
        shell_println!("  CPU count:         {}", cpu_count);
        shell_println!("  APIC:              Active");
    } else {
        shell_println!("  APIC:              Not initialized");
        shell_println!("  Mode:              Legacy PIC");
    }

    shell_println!("");
    Ok(())
}

/// Reboot the system.
pub(super) fn cmd_reboot_impl(_args: &[String]) -> Result<(), ShellError> {
    shell_println!("Rebooting system...");
    unsafe {
        crate::arch::x86_64::cli();
        crate::arch::x86_64::io::outb(0x64, 0xFE);
        loop {
            crate::arch::x86_64::hlt();
        }
    }
}

/// trace mem on|off|dump [n]|clear|serial on|off|mask
pub(super) fn cmd_trace_impl(args: &[String]) -> Result<(), ShellError> {
    if args.is_empty() || args[0].as_str() != "mem" {
        shell_println!("Usage: trace mem on|off|dump [n]|clear|serial on|off|mask");
        return Err(ShellError::InvalidArguments);
    }

    if args.len() < 2 {
        shell_println!("Usage: trace mem on|off|dump [n]|clear|serial on|off|mask");
        return Err(ShellError::InvalidArguments);
    }

    match args[1].as_str() {
        "on" => {
            crate::trace::enable(crate::trace::category::MEM_ALL);
            shell_println!(
                "trace mem: on (mask={:#x}, mode={})",
                crate::trace::mask(),
                crate::trace::mask_human(crate::trace::mask())
            );
            Ok(())
        }
        "off" => {
            crate::trace::disable(crate::trace::category::MEM_ALL);
            shell_println!(
                "trace mem: off (mask={:#x}, mode={})",
                crate::trace::mask(),
                crate::trace::mask_human(crate::trace::mask())
            );
            Ok(())
        }
        "mask" => {
            let stats = crate::trace::stats();
            shell_println!(
                "trace mem: mask={:#x} mode={} serial={} stored={} dropped={}",
                crate::trace::mask(),
                crate::trace::mask_human(crate::trace::mask()),
                if crate::trace::serial_echo() {
                    "on"
                } else {
                    "off"
                },
                stats.stored,
                stats.dropped
            );
            Ok(())
        }
        "clear" => {
            crate::trace::clear_all();
            shell_println!("trace mem: buffers cleared");
            Ok(())
        }
        "serial" => {
            if args.len() != 3 {
                shell_println!("Usage: trace mem serial on|off");
                return Err(ShellError::InvalidArguments);
            }
            match args[2].as_str() {
                "on" => {
                    crate::trace::set_serial_echo(true);
                    shell_println!("trace mem serial: on");
                    Ok(())
                }
                "off" => {
                    crate::trace::set_serial_echo(false);
                    shell_println!("trace mem serial: off");
                    Ok(())
                }
                _ => {
                    shell_println!("Usage: trace mem serial on|off");
                    Err(ShellError::InvalidArguments)
                }
            }
        }
        "dump" => {
            let limit = if args.len() >= 3 {
                args[2].parse::<usize>().unwrap_or(64)
            } else {
                64
            };
            let events = crate::trace::snapshot_all(limit);
            let stats = crate::trace::stats();
            shell_println!(
                "trace mem dump: events={} stored={} dropped={}",
                events.len(),
                stats.stored,
                stats.dropped
            );
            for e in events.iter() {
                shell_println!(
                    "  seq={} t={} cpu={} kind={} pid={} tid={} cr3={:#x} rip={:#x} vaddr={:#x} fl={:#x} a0={:#x} a1={:#x}",
                    e.seq,
                    e.ticks,
                    e.cpu,
                    crate::trace::kind_name(e.kind),
                    e.pid,
                    e.tid,
                    e.cr3,
                    e.rip,
                    e.vaddr,
                    e.flags,
                    e.arg0,
                    e.arg1
                );
            }
            Ok(())
        }
        _ => {
            shell_println!("Usage: trace mem on|off|dump [n]|clear|serial on|off|mask");
            Err(ShellError::InvalidArguments)
        }
    }
}

/// Launch the userspace PID test binary from initfs.
pub(super) fn cmd_test_pid_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_pid";
    shell_println!("Launching {} ...", path);

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_pid") {
        Ok(task_id) => {
            shell_println!("test_pid started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Launch the userspace syscall integration test binary from initfs.
pub(super) fn cmd_test_syscalls_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_syscalls";
    shell_println!("Launching {} ...", path);

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_syscalls") {
        Ok(task_id) => {
            shell_println!("test_syscalls started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Launch the userspace memory test binary from initfs.
pub(super) fn cmd_test_mem_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_mem";
    shell_println!("Launching {} ...", path);

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_mem") {
        Ok(task_id) => {
            shell_println!("test_mem started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Launch the userspace stressed memory test binary from initfs.
pub(super) fn cmd_test_mem_stressed_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_mem_stressed";
    shell_println!("Launching {} ...", path);

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_mem_stressed") {
        Ok(task_id) => {
            shell_println!("test_mem_stressed started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Launch the userspace public MemoryRegion test binary from initfs.
pub(super) fn cmd_test_mem_region_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_mem_region";
    shell_println!("Launching {} ...", path);

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_mem_region") {
        Ok(task_id) => {
            shell_println!("test_mem_region started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Launch the userspace multi-process MemoryRegion test binary from initfs.
pub(super) fn cmd_test_mem_region_proc_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_mem_region_proc";
    shell_println!("Launching {} ...", path);

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_mem_region_proc") {
        Ok(task_id) => {
            shell_println!("test_mem_region_proc started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Ensure a boot module is visible in /initfs and return its bytes.
fn initfs_or_boot_module(path: &'static str, module: Option<(u64, u64)>) -> Option<&'static [u8]> {
    if let Some(bytes) = vfs::get_initfs_file_bytes(path) {
        return Some(bytes);
    }

    let (base, size) = module?;
    if base == 0 || size == 0 {
        return None;
    }

    let base_virt = memory::phys_to_virt(base) as *const u8;
    if vfs::register_initfs_file(path, base_virt, size as usize).is_err() {
        return None;
    }

    vfs::get_initfs_file_bytes(path)
}

/// Launch the userspace exec regression test binary from initfs.
pub(super) fn cmd_test_exec_impl(_args: &[String]) -> Result<(), ShellError> {
    let path = "/initfs/test_exec";
    shell_println!("Launching {} ...", path);

    let boot_bytes = initfs_or_boot_module(path, crate::boot::limine::test_exec_module());
    let _ = initfs_or_boot_module(
        "/initfs/test_exec_helper",
        crate::boot::limine::test_exec_helper_module(),
    );

    if let Some(data) = boot_bytes {
        shell_println!("ELF size: {} bytes", data.len());
        return match load_and_run_elf(data, "test_exec") {
            Ok(task_id) => {
                shell_println!("test_exec started (task id={})", task_id);
                Ok(())
            }
            Err(e) => {
                shell_println!("load_and_run_elf failed: {}", e);
                Err(ShellError::ExecutionFailed)
            }
        };
    }

    let fd = match vfs::open(path, vfs::OpenFlags::READ) {
        Ok(fd) => fd,
        Err(e) => {
            shell_println!("open failed: {:?}", e);
            if crate::boot::limine::test_exec_module().is_none() {
                shell_println!(
                    "test_exec boot module missing from current image; rebuild the userspace image so /initfs/test_exec is copied"
                );
            }
            return Err(ShellError::ExecutionFailed);
        }
    };

    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(e) => {
            let _ = vfs::close(fd);
            shell_println!("read failed: {:?}", e);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    shell_println!("ELF size: {} bytes", data.len());
    match load_and_run_elf(&data, "test_exec") {
        Ok(task_id) => {
            shell_println!("test_exec started (task id={})", task_id);
            Ok(())
        }
        Err(e) => {
            shell_println!("load_and_run_elf failed: {}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Performs the cmd silo list operation.
fn cmd_silo_list(args: &[String]) -> Result<(), ShellError> {
    let mut want_gui = false;
    for arg in args.iter().skip(1) {
        match arg.as_str() {
            "--gui" => want_gui = true,
            _ => {
                shell_println!("Usage: silo list [--gui]");
                return Err(ShellError::InvalidArguments);
            }
        }
    }

    let (managed, managed_source) = load_managed_silos_with_source();
    let managed_runtime_sids = compute_managed_runtime_sids(&managed);
    let mut silos = silo::list_silos_snapshot();
    silos.sort_by_key(|s| s.id);

    let mut rows: Vec<SiloListRow> = Vec::new();
    let mut config_rows: Vec<ConfigListRow> = Vec::new();

    for m in &managed {
        let mut strates = Vec::new();
        for st in &m.strates {
            if !st.name.is_empty() {
                push_unique(&mut strates, &st.name);
            }
        }
        config_rows.push(ConfigListRow {
            sid: managed_runtime_sids
                .iter()
                .find(|(name, _)| *name == m.name)
                .map(|(_, sid)| *sid)
                .unwrap_or(m.sid),
            name: m.name.clone(),
            family: m.family.clone(),
            mode: m.mode.clone(),
            strates: join_csv(&strates),
        });
    }

    for s in silos.iter() {
        let display_name = managed_name_for_runtime_sid(&managed_runtime_sids, s.id)
            .unwrap_or_else(|| s.name.clone());
        let label = s.strate_label.clone().unwrap_or_else(|| String::from("-"));
        let mut strates = Vec::new();
        for m in &managed {
            if managed_runtime_sids
                .iter()
                .any(|(name, sid)| *sid == s.id && *name == m.name)
            {
                for st in &m.strates {
                    if !st.name.is_empty() {
                        push_unique(&mut strates, &st.name);
                    }
                }
            }
        }
        if strates.is_empty() && label != "-" {
            strates.push(alloc::format!("{} (kernel)", label));
        }
        let strates_cell = join_csv(&strates);
        let (used_val, used_unit) = format_bytes(s.mem_usage_bytes as usize);
        let mem_cell = if s.mem_max_bytes == 0 {
            alloc::format!("{} {} / unlimited", used_val, used_unit)
        } else {
            let (max_val, max_unit) = format_bytes(s.mem_max_bytes as usize);
            alloc::format!("{} {} / {} {}", used_val, used_unit, max_val, max_unit)
        };
        rows.push(SiloListRow {
            sid: s.id,
            name: display_name,
            state: alloc::format!("{:?}", s.state),
            tasks: s.task_count,
            memory: mem_cell,
            mode: s.mode,
            label,
            strates: strates_cell,
        });
    }
    if want_gui {
        if render_silo_table_ratatui(&rows, &config_rows, managed_source).unwrap_or(false) {
            return Ok(());
        }
        shell_println!("silo list: GUI unavailable, fallback console");
    }

    shell_println!(
        "{:<6} {:<14} {:<10} {:<7} {:<18} {:<6} {:<12} {}",
        "SID",
        "Name",
        "State",
        "Tasks",
        "Memory",
        "Mode",
        "Label",
        "Strates"
    );
    shell_println!("====================================================================================================================================================================================");
    for r in rows {
        shell_println!(
            "{:<6} {:<12} {:<10} {:<7} {:<18} {:<6o} {:<12} {}",
            r.sid,
            r.name,
            r.state,
            r.tasks,
            r.memory,
            r.mode,
            r.label,
            r.strates
        );
    }
    Ok(())
}

/// Performs the cmd strate list operation.
fn cmd_strate_list(_args: &[String]) -> Result<(), ShellError> {
    struct StrateEntry {
        name: String,
        belongs_to: Vec<String>,
    }

    let (managed, managed_source) = load_managed_silos_with_source();
    let mut entries: Vec<StrateEntry> = Vec::new();

    for s in &managed {
        for st in &s.strates {
            if st.name.is_empty() {
                continue;
            }
            if let Some(e) = entries.iter_mut().find(|e| e.name == st.name) {
                push_unique(&mut e.belongs_to, &s.name);
            } else {
                entries.push(StrateEntry {
                    name: st.name.clone(),
                    belongs_to: alloc::vec![s.name.clone()],
                });
            }
        }
    }

    let mut runtime_entries: Vec<StrateEntry> = Vec::new();
    for runtime in silo::list_silos_snapshot() {
        let mut names: Vec<String> = Vec::new();
        for m in &managed {
            if m.name == runtime.name || m.sid == runtime.id {
                for st in &m.strates {
                    if !st.name.is_empty() {
                        push_unique(&mut names, &st.name);
                    }
                }
            }
        }
        if names.is_empty() {
            if let Some(label) = runtime.strate_label {
                names.push(label);
            } else {
                continue;
            }
        }

        for name in names {
            if let Some(e) = runtime_entries.iter_mut().find(|e| e.name == name) {
                push_unique(&mut e.belongs_to, &runtime.name);
            } else {
                runtime_entries.push(StrateEntry {
                    name,
                    belongs_to: alloc::vec![runtime.name.clone()],
                });
            }
        }
    }

    entries.sort_by(|a, b| a.name.cmp(&b.name));
    runtime_entries.sort_by(|a, b| a.name.cmp(&b.name));

    let config_rows: Vec<ConfigStrateRow> = entries
        .iter()
        .map(|e| ConfigStrateRow {
            strate: e.name.clone(),
            belongs_to: join_csv(&e.belongs_to),
        })
        .collect();

    let runtime_rows: Vec<RuntimeStrateRow> = runtime_entries
        .iter()
        .map(|e| {
            let in_cfg = entries.iter().any(|cfg| cfg.name == e.name);
            RuntimeStrateRow {
                strate: e.name.clone(),
                belongs_to: join_csv(&e.belongs_to),
                status: if in_cfg {
                    String::from("config+runtime")
                } else {
                    String::from("runtime-only")
                },
            }
        })
        .collect();

    if render_strate_table_ratatui(&runtime_rows, &config_rows, managed_source).unwrap_or(false) {
        return Ok(());
    }

    shell_println!("Runtime:");
    shell_println!("{:<20} {:<24} {}", "Strate", "BelongsTo", "Status");
    shell_println!("====================");
    for r in runtime_rows {
        shell_println!("{:<20} {:<24} {}", r.strate, r.belongs_to, r.status);
    }
    shell_println!("");
    shell_println!("Config ({}):", managed_source);
    shell_println!("{:<20} {}", "Strate", "BelongsTo");
    shell_println!("====================");
    for r in config_rows {
        shell_println!("{:<20} {}", r.strate, r.belongs_to);
    }
    Ok(())
}

fn cmd_strate_spawn(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!(
            "Usage: strate spawn <path|type> [--label <l>] [--dev <p>] [--type elf|wasm]"
        );
        return Err(ShellError::InvalidArguments);
    }
    let target = args[1].as_str();

    let mut label: Option<&str> = None;
    let mut dev: Option<&str> = None;
    let mut spawn_type: Option<&str> = None;
    let mut i = 2usize;
    while i < args.len() {
        match args[i].as_str() {
            "--label" => {
                if i + 1 >= args.len() {
                    return Err(ShellError::InvalidArguments);
                }
                label = Some(args[i + 1].as_str());
                i += 2;
            }
            "--dev" => {
                if i + 1 >= args.len() {
                    return Err(ShellError::InvalidArguments);
                }
                dev = Some(args[i + 1].as_str());
                i += 2;
            }
            "--type" => {
                if i + 1 >= args.len() {
                    return Err(ShellError::InvalidArguments);
                }
                spawn_type = Some(args[i + 1].as_str());
                i += 2;
            }
            _ => {
                shell_println!("strate spawn: unknown option '{}'", args[i]);
                return Err(ShellError::InvalidArguments);
            }
        }
    }

    let module_path: String = match target {
        "strate-fs-ext4" => String::from("/initfs/fs-ext4"),
        "ramfs" | "strate-fs-ramfs" => String::from("/initfs/strate-fs-ramfs"),
        path if path.starts_with('/') => String::from(path),
        name => {
            let mut p = String::from("/initfs/bin/");
            p.push_str(name);
            p
        }
    };

    if spawn_type == Some("wasm") {
        shell_println!("strate spawn: delegating wasm to wasm-run...");
        return cmd_wasm_run(&[String::from(target)]);
    }

    let fd = vfs::open(&module_path, vfs::OpenFlags::READ).map_err(|_| {
        shell_println!("strate spawn: cannot open '{}'", module_path);
        ShellError::ExecutionFailed
    })?;
    let data = match vfs::read_all(fd) {
        Ok(d) => d,
        Err(_) => {
            let _ = vfs::close(fd);
            shell_println!("strate spawn: cannot read '{}'", module_path);
            return Err(ShellError::ExecutionFailed);
        }
    };
    let _ = vfs::close(fd);

    match silo::kernel_spawn_strate(&data, label, dev) {
        Ok(sid) => {
            shell_println!(
                "strate spawn: started (sid={}, path={}, label={})",
                sid,
                module_path,
                label.unwrap_or("-")
            );
            Ok(())
        }
        Err(e) => {
            shell_println!("strate spawn failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Performs the cmd strate config show operation.
fn cmd_strate_config_show(args: &[String]) -> Result<(), ShellError> {
    let existing = read_silo_toml_from_initfs()?;
    let silos = parse_silo_toml(&existing);
    if silos.is_empty() {
        shell_println!("strate config show: /initfs/silo.toml empty or missing");
        return Ok(());
    }

    if args.len() == 3 {
        let name = args[2].as_str();
        let Some(s) = silos.iter().find(|s| s.name == name) else {
            shell_println!("strate config show: silo '{}' not found", name);
            return Err(ShellError::ExecutionFailed);
        };
        shell_println!(
            "silo '{}' sid={} family={} mode={} strates={}",
            s.name,
            s.sid,
            s.family,
            s.mode,
            s.strates.len()
        );
        for st in &s.strates {
            shell_println!(
                "  - {}: binary={} type={} target={}",
                st.name,
                st.binary,
                st.stype,
                st.target
            );
        }
        return Ok(());
    }

    for s in &silos {
        shell_println!(
            "silo '{}' sid={} family={} mode={} strates={}",
            s.name,
            s.sid,
            s.family,
            s.mode,
            s.strates.len()
        );
    }
    Ok(())
}

/// Performs the cmd strate config add operation.
fn cmd_strate_config_add(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 5 {
        shell_println!("Usage: strate config add <silo> <name> <binary> [--type <t>] [--target <x>] [--family <F>] [--mode <ooo>] [--sid <n>]");
        return Err(ShellError::InvalidArguments);
    }
    let silo_name = args[2].as_str();
    let strate_name = args[3].as_str();
    let binary = args[4].as_str();
    if silo_name.is_empty() || strate_name.is_empty() || binary.is_empty() {
        shell_println!("strate config add: invalid empty argument");
        return Err(ShellError::InvalidArguments);
    }

    let mut stype = String::from("elf");
    let mut target = String::from("default");
    let mut family: Option<String> = None;
    let mut mode: Option<String> = None;
    let mut sid: Option<u32> = None;
    let mut i = 5usize;
    while i < args.len() {
        match args[i].as_str() {
            "--type" => {
                if i + 1 >= args.len() {
                    shell_println!("strate config add: missing value for --type");
                    return Err(ShellError::InvalidArguments);
                }
                stype = args[i + 1].clone();
                i += 2;
            }
            "--target" => {
                if i + 1 >= args.len() {
                    shell_println!("strate config add: missing value for --target");
                    return Err(ShellError::InvalidArguments);
                }
                target = args[i + 1].clone();
                i += 2;
            }
            "--family" => {
                if i + 1 >= args.len() {
                    shell_println!("strate config add: missing value for --family");
                    return Err(ShellError::InvalidArguments);
                }
                family = Some(args[i + 1].clone());
                i += 2;
            }
            "--mode" => {
                if i + 1 >= args.len() {
                    shell_println!("strate config add: missing value for --mode");
                    return Err(ShellError::InvalidArguments);
                }
                mode = Some(args[i + 1].clone());
                i += 2;
            }
            "--sid" => {
                if i + 1 >= args.len() {
                    shell_println!("strate config add: missing value for --sid");
                    return Err(ShellError::InvalidArguments);
                }
                sid = args[i + 1].parse::<u32>().ok();
                if sid.is_none() {
                    shell_println!("strate config add: invalid --sid");
                    return Err(ShellError::InvalidArguments);
                }
                i += 2;
            }
            other => {
                shell_println!("strate config add: unknown option '{}'", other);
                return Err(ShellError::InvalidArguments);
            }
        }
    }

    let existing = read_silo_toml_from_initfs()?;
    let mut silos = parse_silo_toml(&existing);
    let idx = match silos.iter().position(|s| s.name == silo_name) {
        Some(p) => p,
        None => {
            silos.push(ManagedSiloDef {
                name: String::from(silo_name),
                sid: sid.unwrap_or(42),
                family: family.clone().unwrap_or_else(|| String::from("USR")),
                mode: mode.clone().unwrap_or_else(|| String::from("000")),
                cpu_features: String::new(),
                graphics_enabled: false,
                graphics_mode: String::new(),
                graphics_read_only: false,
                graphics_max_sessions: 0,
                graphics_session_ttl_sec: 0,
                graphics_turn_policy: String::from("auto"),
                strates: Vec::new(),
            });
            silos.len() - 1
        }
    };

    if let Some(f) = family {
        silos[idx].family = f;
    }
    if let Some(m) = mode {
        silos[idx].mode = m;
    }
    if let Some(s) = sid {
        silos[idx].sid = s;
    }

    if let Some(st) = silos[idx]
        .strates
        .iter_mut()
        .find(|st| st.name == strate_name)
    {
        st.binary = String::from(binary);
        st.stype = stype;
        st.target = target;
    } else {
        silos[idx].strates.push(ManagedStrateDef {
            name: String::from(strate_name),
            binary: String::from(binary),
            stype,
            target,
        });
    }

    let rendered = render_silo_toml(&silos);
    write_silo_toml_to_initfs(&rendered)?;
    shell_println!(
        "strate config add: wrote /initfs/silo.toml (silo='{}', strate='{}')",
        silo_name,
        strate_name
    );
    Ok(())
}

/// Performs the cmd strate config remove operation.
fn cmd_strate_config_remove(args: &[String]) -> Result<(), ShellError> {
    if args.len() != 4 {
        shell_println!("Usage: strate config remove <silo> <name>");
        return Err(ShellError::InvalidArguments);
    }
    let silo_name = args[2].as_str();
    let strate_name = args[3].as_str();
    let existing = read_silo_toml_from_initfs()?;
    let mut silos = parse_silo_toml(&existing);

    let Some(silo_idx) = silos.iter().position(|s| s.name == silo_name) else {
        shell_println!("strate config remove: silo '{}' not found", silo_name);
        return Err(ShellError::ExecutionFailed);
    };
    let Some(strate_idx) = silos[silo_idx]
        .strates
        .iter()
        .position(|st| st.name == strate_name)
    else {
        shell_println!(
            "strate config remove: strate '{}' not found in silo '{}'",
            strate_name,
            silo_name
        );
        return Err(ShellError::ExecutionFailed);
    };

    silos[silo_idx].strates.remove(strate_idx);
    if silos[silo_idx].strates.is_empty() {
        silos.remove(silo_idx);
    }

    let rendered = render_silo_toml(&silos);
    write_silo_toml_to_initfs(&rendered)?;
    shell_println!(
        "strate config remove: updated /initfs/silo.toml (silo='{}', strate='{}')",
        silo_name,
        strate_name
    );
    Ok(())
}

/// Performs the cmd strate config operation.
fn cmd_strate_config(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!("Usage: strate config <show|add|remove> ...");
        return Err(ShellError::InvalidArguments);
    }
    match args[1].as_str() {
        "show" => cmd_strate_config_show(args),
        "add" => cmd_strate_config_add(args),
        "remove" => cmd_strate_config_remove(args),
        _ => {
            shell_println!("Usage: strate config <show|add|remove> ...");
            Err(ShellError::InvalidArguments)
        }
    }
}

/// Performs the cmd strate start operation.
fn cmd_strate_start(args: &[String]) -> Result<(), ShellError> {
    if args.len() != 2 {
        shell_println!("Usage: strate start <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    match silo::kernel_start_silo(selector.as_str()) {
        Ok(sid) => {
            shell_println!("strate start: ok (sid={})", sid);
            print_strate_state_for_sid(sid);
            Ok(())
        }
        Err(e) => {
            shell_println!("strate start failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Performs the cmd strate lifecycle operation.
fn cmd_strate_lifecycle(args: &[String]) -> Result<(), ShellError> {
    if args.len() != 2 {
        shell_println!("Usage: strate start|stop|kill|destroy <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    let action = args[0].as_str();
    let result = match action {
        "stop" => silo::kernel_stop_silo(selector.as_str(), false),
        "kill" => silo::kernel_stop_silo(selector.as_str(), true),
        "destroy" => silo::kernel_destroy_silo(selector.as_str()),
        _ => unreachable!(),
    };
    match result {
        Ok(sid) => {
            shell_println!("strate {}: ok (sid={})", action, sid);
            if action == "stop" {
                print_strate_state_for_sid(sid);
            }
            Ok(())
        }
        Err(e) => {
            shell_println!("strate {} failed: {:?}", action, e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

/// Performs the cmd strate rename operation.
fn cmd_strate_rename(args: &[String]) -> Result<(), ShellError> {
    if args.len() != 3 {
        shell_println!("Usage: strate rename <id|label|name> <new_label>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    let new_label = args[2].as_str();
    match silo::kernel_rename_silo_label(selector.as_str(), new_label) {
        Ok(sid) => {
            shell_println!("strate rename: ok (sid={}, new_label={})", sid, new_label);
            Ok(())
        }
        Err(e) => {
            if matches!(e, crate::syscall::error::SyscallError::InvalidArgument) {
                shell_println!(
                    "strate rename failed: strate is running or not in a renamable state (stop it first)"
                );
            } else {
                shell_println!("strate rename failed: {:?}", e);
            }
            Err(ShellError::ExecutionFailed)
        }
    }
}

pub(super) fn cmd_strate_impl(args: &[String]) -> Result<(), ShellError> {
    if args.is_empty() {
        print_strate_usage();
        return Err(ShellError::InvalidArguments);
    }

    match args[0].as_str() {
        "list" => cmd_strate_list(args),
        "spawn" => cmd_strate_spawn(args),
        "config" => cmd_strate_config(args),
        "start" => cmd_strate_start(args),
        "stop" | "kill" | "destroy" => cmd_strate_lifecycle(args),
        "rename" => cmd_strate_rename(args),
        "info" => cmd_silo_info(args),
        "suspend" => cmd_silo_suspend(args),
        "resume" => cmd_silo_resume(args),
        "events" => cmd_silo_events(args),
        "pledge" => cmd_silo_pledge(args),
        "unveil" => cmd_silo_unveil(args),
        "sandbox" => cmd_silo_sandbox(args),
        "limit" => cmd_silo_limit(args),
        "attach" => cmd_silo_attach(args),
        "top" => cmd_silo_top(args),
        "logs" => cmd_silo_logs(args),
        _ => {
            print_strate_usage();
            Err(ShellError::InvalidArguments)
        }
    }
}

// ============================================================================
// silo info / suspend / resume / events / pledge / unveil / sandbox / top / logs
// ============================================================================
fn cmd_silo_info(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!("Usage: silo info <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    let detail = silo::silo_detail_snapshot(selector.as_str()).map_err(|e| {
        shell_println!("silo info: {:?}", e);
        ShellError::ExecutionFailed
    })?;
    let b = &detail.base;
    let (used_v, used_u) = format_bytes(b.mem_usage_bytes as usize);
    let (min_v, min_u) = format_bytes(b.mem_min_bytes as usize);
    let mem_max = if b.mem_max_bytes == 0 {
        String::from("unlimited")
    } else {
        let (v, u) = format_bytes(b.mem_max_bytes as usize);
        alloc::format!("{} {}", v, u)
    };

    shell_println!("SID:        {}", b.id);
    shell_println!("Name:       {}", b.name);
    shell_println!("Label:      {}", b.strate_label.as_deref().unwrap_or("-"));
    shell_println!("Tier:       {:?}", b.tier);
    shell_println!("State:      {:?}", b.state);
    shell_println!("Family:     {:?}", detail.family);
    shell_println!("Mode:       {:03o}", b.mode);
    shell_println!("Sandboxed:  {}", detail.sandboxed);
    shell_println!("Tasks:      {}", b.task_count);
    shell_println!(
        "Memory:     {} {} / {} {} / {}",
        used_v,
        used_u,
        min_v,
        min_u,
        mem_max
    );
    shell_println!("CPU shares: {}", detail.cpu_shares);
    shell_println!("CPU mask:   {:#x}", detail.cpu_affinity_mask);
    shell_println!("CPU req:    {:#x}", detail.cpu_features_required);
    shell_println!("CPU allow:  {:#x}", detail.cpu_features_allowed);
    shell_println!("XCR0 mask:  {:#x}", detail.xcr0_mask);
    shell_println!("GFX flags:  {:#x}", detail.graphics_flags);
    shell_println!(
        "GFX mode:   {}",
        if (detail.graphics_flags & (1 << 2)) != 0 {
            "webrtc-native"
        } else if (detail.graphics_flags & (1 << 1)) != 0 {
            "graphics-raw"
        } else {
            "disabled"
        }
    );
    shell_println!(
        "GFX ro:     {}",
        if (detail.graphics_flags & (1 << 3)) != 0 {
            "true"
        } else {
            "false"
        }
    );
    shell_println!("GFX sess:   {}", detail.graphics_max_sessions);
    shell_println!("GFX ttl:    {} sec", detail.graphics_session_ttl_sec);
    shell_println!(
        "Max tasks:  {}",
        if detail.max_tasks == 0 {
            String::from("unlimited")
        } else {
            alloc::format!("{}", detail.max_tasks)
        }
    );
    shell_println!("Caps:       {} granted", detail.granted_caps_count);

    if !detail.task_ids.is_empty() {
        shell_println!("Task IDs:   {:?}", detail.task_ids);
    }

    if !detail.unveil_rules.is_empty() {
        shell_println!("Unveil rules:");
        for (path, bits) in &detail.unveil_rules {
            let r = if bits & 4 != 0 { 'r' } else { '-' };
            let w = if bits & 2 != 0 { 'w' } else { '-' };
            let x = if bits & 1 != 0 { 'x' } else { '-' };
            shell_println!("  {}{}{} {}", r, w, x, path);
        }
    }
    Ok(())
}

fn cmd_silo_suspend(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!("Usage: silo suspend <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    match silo::kernel_suspend_silo(selector.as_str()) {
        Ok(sid) => {
            shell_println!("silo suspend: ok (sid={})", sid);
            Ok(())
        }
        Err(e) => {
            shell_println!("silo suspend failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

fn cmd_silo_resume(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!("Usage: silo resume <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    match silo::kernel_resume_silo(selector.as_str()) {
        Ok(sid) => {
            shell_println!("silo resume: ok (sid={})", sid);
            Ok(())
        }
        Err(e) => {
            shell_println!("silo resume failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

fn event_kind_str(kind: silo::SiloEventKind) -> &'static str {
    match kind {
        silo::SiloEventKind::Started => "Started",
        silo::SiloEventKind::Stopped => "Stopped",
        silo::SiloEventKind::Killed => "Killed",
        silo::SiloEventKind::Crashed => "Crashed",
        silo::SiloEventKind::Paused => "Paused",
        silo::SiloEventKind::Resumed => "Resumed",
    }
}

fn cmd_silo_events(args: &[String]) -> Result<(), ShellError> {
    let events = if args.len() >= 2 {
        let selector = normalize_current_silo_selector(args[1].as_str());
        silo::list_events_for_silo(selector.as_str()).map_err(|e| {
            shell_println!("silo events: {:?}", e);
            ShellError::ExecutionFailed
        })?
    } else {
        silo::list_events_snapshot()
    };

    if events.is_empty() {
        shell_println!("(no events)");
        return Ok(());
    }

    shell_println!(
        "{:<8} {:<10} {:<12} {:<12} {}",
        "SID",
        "Kind",
        "Data0",
        "Data1",
        "Tick"
    );
    shell_println!("==========");
    for ev in &events {
        shell_println!(
            "{:<8} {:<10} {:#010x}   {:#010x}   {}",
            ev.silo_id,
            event_kind_str(ev.kind),
            ev.data0,
            ev.data1,
            ev.tick
        );
    }
    Ok(())
}

fn cmd_silo_pledge(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 3 {
        shell_println!("Usage: silo pledge <id|label|name> <octal_mode>");
        return Err(ShellError::InvalidArguments);
    }
    let mode_val = u16::from_str_radix(args[2].as_str(), 8).map_err(|_| {
        shell_println!("silo pledge: invalid octal mode '{}'", args[2]);
        ShellError::InvalidArguments
    })?;
    let selector = normalize_current_silo_selector(args[1].as_str());
    match silo::kernel_pledge_silo(selector.as_str(), mode_val) {
        Ok((old, new)) => {
            shell_println!("silo pledge: {:03o} -> {:03o}", old, new);
            Ok(())
        }
        Err(e) => {
            shell_println!("silo pledge failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

fn cmd_silo_unveil(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 4 {
        shell_println!("Usage: silo unveil <id|label|name> <path> <rwx>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    let path = args[2].as_str();
    let rights = args[3].as_str();
    match silo::kernel_unveil_silo(selector.as_str(), path, rights) {
        Ok(sid) => {
            shell_println!(
                "silo unveil: ok (sid={}, path={}, rights={})",
                sid,
                path,
                rights
            );
            Ok(())
        }
        Err(e) => {
            shell_println!("silo unveil failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

fn cmd_silo_sandbox(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!("Usage: silo sandbox <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    match silo::kernel_sandbox_silo(selector.as_str()) {
        Ok(sid) => {
            shell_println!("silo sandbox: ok (sid={})", sid);
            Ok(())
        }
        Err(e) => {
            shell_println!("silo sandbox failed: {:?}", e);
            Err(ShellError::ExecutionFailed)
        }
    }
}

fn cmd_silo_top(_args: &[String]) -> Result<(), ShellError> {
    let mut silos = silo::list_silos_snapshot();

    let sort_by_mem = _args.len() >= 3 && _args[1] == "--sort" && _args[2] == "mem";
    if sort_by_mem {
        silos.sort_by(|a, b| b.mem_usage_bytes.cmp(&a.mem_usage_bytes));
    } else {
        silos.sort_by(|a, b| {
            b.task_count
                .cmp(&a.task_count)
                .then(b.mem_usage_bytes.cmp(&a.mem_usage_bytes))
        });
    }

    let total_tasks: usize = silos.iter().map(|s| s.task_count).sum();
    let total_mem: u64 = silos.iter().map(|s| s.mem_usage_bytes).sum();
    let (tm_v, tm_u) = format_bytes(total_mem as usize);

    shell_println!(
        "Silos: {}   Tasks: {}   Memory: {} {}",
        silos.len(),
        total_tasks,
        tm_v,
        tm_u
    );
    shell_println!("");
    shell_println!(
        "{:<6} {:<14} {:<10} {:<7} {:<16} {:<6}",
        "SID",
        "Name",
        "State",
        "Tasks",
        "Memory",
        "Mode"
    );
    shell_println!("========================================");
    for s in &silos {
        let (mv, mu) = format_bytes(s.mem_usage_bytes as usize);
        let mem_str = alloc::format!("{} {}", mv, mu);
        shell_println!(
            "{:<6} {:<14} {:<10} {:<7} {:<16} {:03o}",
            s.id,
            s.name,
            alloc::format!("{:?}", s.state),
            s.task_count,
            mem_str,
            s.mode
        );
    }
    Ok(())
}

fn cmd_silo_logs(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 2 {
        shell_println!("Usage: silo logs <id|label|name>");
        return Err(ShellError::InvalidArguments);
    }
    let selector = normalize_current_silo_selector(args[1].as_str());
    let events = silo::list_events_for_silo(selector.as_str()).map_err(|e| {
        shell_println!("silo logs: {:?}", e);
        ShellError::ExecutionFailed
    })?;
    if events.is_empty() {
        shell_println!("(no log entries for this silo)");
        return Ok(());
    }
    for ev in &events {
        let tick_s = ev.tick / 100;
        let tick_cs = ev.tick % 100;
        shell_println!(
            "[{:>6}.{:02}] sid={} {}",
            tick_s,
            tick_cs,
            ev.silo_id,
            event_kind_str(ev.kind)
        );
    }
    Ok(())
}

pub(super) fn cmd_wasm_run_impl(args: &[String]) -> Result<(), ShellError> {
    if args.len() < 1 {
        shell_println!("Usage: wasm-run <path>");
        return Err(ShellError::InvalidArguments);
    }
    let wasm_path = &args[0];

    shell_println!("wasm-run: using running strate-wasm service...");
    let default_service_path = String::from("/srv/strate-wasm/default");
    let bootstrap_service_path = String::from("/srv/strate-wasm/bootstrap");
    shell_println!("wasm-run: waiting for service {} ...", default_service_path);

    let mut selected_service_path: Option<String> = None;
    for _ in 0..100 {
        if crate::shell::is_interrupted() {
            shell_println!("wasm-run: cancelled");
            return Err(ShellError::ExecutionFailed);
        }
        if vfs::stat_path(&default_service_path).is_ok() {
            selected_service_path = Some(default_service_path.clone());
            break;
        }
        if vfs::stat_path(&bootstrap_service_path).is_ok() {
            selected_service_path = Some(bootstrap_service_path.clone());
            break;
        }
        crate::process::yield_task();
    }

    let Some(service_path) = selected_service_path else {
        shell_println!("wasm-run: timed out waiting for /srv/strate-wasm/default");
        return Err(ShellError::ExecutionFailed);
    };

    // Connect and send LOAD then RUN
    let (scheme, rel) = vfs::resolve(&service_path).map_err(|_| ShellError::ExecutionFailed)?;
    let open_res = scheme
        .open(&rel, vfs::OpenFlags::READ)
        .map_err(|_| ShellError::ExecutionFailed)?;
    let port_id = crate::ipc::PortId::from_u64(open_res.file_id);
    let port = crate::ipc::port::get_port(port_id).ok_or(ShellError::ExecutionFailed)?;

    let mut load_msg = crate::ipc::IpcMessage::new(0x100);
    let path_bytes = wasm_path.as_bytes();
    let copy_len = core::cmp::min(path_bytes.len(), 63);
    load_msg.payload[0] = copy_len as u8;
    load_msg.payload[1..1 + copy_len].copy_from_slice(&path_bytes[..copy_len]);

    shell_println!("wasm-run: loading {} ...", wasm_path);
    port.send(load_msg)
        .map_err(|_| ShellError::ExecutionFailed)?;

    let load_ack = port.recv().map_err(|_| ShellError::ExecutionFailed)?;
    let load_status = u32::from_le_bytes([
        load_ack.payload[0],
        load_ack.payload[1],
        load_ack.payload[2],
        load_ack.payload[3],
    ]);
    if load_status != 0 {
        shell_println!("wasm-run: load failed (status={})", load_status);
        return Err(ShellError::ExecutionFailed);
    }

    let run_msg = crate::ipc::IpcMessage::new(0x102);
    shell_println!("wasm-run: starting execution...");
    port.send(run_msg)
        .map_err(|_| ShellError::ExecutionFailed)?;
    let run_ack = port.recv().map_err(|_| ShellError::ExecutionFailed)?;
    let run_status = u32::from_le_bytes([
        run_ack.payload[0],
        run_ack.payload[1],
        run_ack.payload[2],
        run_ack.payload[3],
    ]);
    if run_status != 0 {
        shell_println!("wasm-run: execution failed (status={})", run_status);
        return Err(ShellError::ExecutionFailed);
    }
    shell_println!("wasm-run: done");

    Ok(())
}

/// `health` : system health diagnostic (boot graph, strates, IPC, VFS mounts).
pub(super) fn cmd_health_impl(_args: &[String]) -> Result<(), ShellError> {
    shell_println!("=== Strat9 Health Report ===\n");

    shell_println!("-- VFS Mounts --");
    for m in vfs::list_mounts() {
        shell_println!("  {}", m);
    }

    shell_println!("\n-- IPC Namespace --");
    let bindings = crate::namespace::list_all_bindings();
    if bindings.is_empty() {
        shell_println!("  (none)");
    } else {
        for (name, port_id) in &bindings {
            shell_println!("  {} -> port {}", name, port_id);
        }
    }

    shell_println!("\n-- Active Silos --");
    let silo_list = silo::list_silos_snapshot();
    if silo_list.is_empty() {
        shell_println!("  (none)");
    } else {
        for info in &silo_list {
            shell_println!(
                "  SID={} name={} state={:?} tasks={}",
                info.id,
                info.name,
                info.state,
                info.task_count
            );
        }
    }

    shell_println!("\n=== End Health Report ===");
    Ok(())
}